Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added an option to copy the User ID from the about page #16213

Merged
merged 13 commits into from
Sep 19, 2024
Merged

Feature: Added an option to copy the User ID from the about page #16213

merged 13 commits into from
Sep 19, 2024

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Sep 17, 2024 •
edited
Loading

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Copy User Id

  1. Opened about page
  2. Confirmed Copy > User Id works as expected

Report Bug

  • Reporting a bug from the about page automatically passes the user id to GitHub

@yaira2 yaira2 requested a review from 0x5bfa September 17, 2024 14:43
0x5bfa
0x5bfa reviewed Sep 17, 2024
View reviewed changes
.github/ISSUE_TEMPLATE/bug_report.yml Outdated Show resolved Hide resolved
src/Files.App/Strings/en-US/Resources.resw Outdated Show resolved Hide resolved
@yaira2 yaira2 requested a review from 0x5bfa September 17, 2024 19:50
@yaira2 yaira2 changed the title Feature: Added an option to copy the User Id from the about page Feature: Added an option to copy the User ID from the about page Sep 17, 2024
0x5bfa
0x5bfa approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@0x5bfa 0x5bfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code wise, LGMT.

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Sep 18, 2024
@yaira2 yaira2 merged commit 8edb6db into main Sep 19, 2024
6 checks passed
@yaira2 yaira2 deleted the ya/UserId branch September 19, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x5bfa 0x5bfa 0x5bfa approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaira2 @0x5bfa