Code Quality: Added root files to projects to make them easier to edit #16815
Conversation
| <ItemGroup> | ||
| <None Include="$(MSBuildThisFileDirectory)\.editorconfig" /> | ||
| <None Include="$(MSBuildThisFileDirectory)\Directory.Build.props" /> | ||
| <None Include="$(MSBuildThisFileDirectory)\Directory.Packages.props" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
This will make them appear on all projects. Instead you should add them as solution items.
I would recommend holding up the change until we migrate to slnx.
There was a problem hiding this comment.
I'm aware of that
There was a problem hiding this comment.
IMO it's a better experience to add them to the project directly as they apply to every project
If it was an explicit .props file that was in the actual project structure then I would add them to the solution, though since these files apply everywhere it makes sense to put them inside every project as None.
There was a problem hiding this comment.
You can create a virtual folder and add them to it in the solution file.
There was a problem hiding this comment.
@Lamparter we've just migrated to slnx and can move forward with these changes now.
Signed-off-by: Lamparter <[email protected]>
Adds
Directory.Packages.props,Directory.Build.propsand.editorconfigto all projects asNoneto make them appear in Solution Explorer. This makes them easier to edit.