Code Quality: Ignored Files.App.Launcher.exe.sha256
#17075
Conversation
There was a problem hiding this comment.
If it's ignored it will get deleted.
There was a problem hiding this comment.
It'll be removed from the repo, or it just won't be included when the repo is cloned?
There was a problem hiding this comment.
TBH theres no reason to keep this file in the repo or on one's local because everytime you run CD, it'll be overridden and either:
- The CD should embed the SHA to the files.exe binary.
- The CD should output the SHA and you should copy&paste to the corresponding release blog.
CC: @hishitetsu I believe you added because we or users better can check the SHA of the binary right?
There was a problem hiding this comment.
because everytime you run CD
Originally the file was only updated when the launcher project was modified, but we lost this behavior with one of our other changes. I'm hoping we can fix the build step at some point, but it's low priority since it doesn't have any impact.
There was a problem hiding this comment.
The important thing is that we should keep the SHA so users can compare on their local but in the first place we have never done so (if Hishitetsu meant so).
There was a problem hiding this comment.
It'll be removed from the repo, or it just won't be included when the repo is cloned?
If it's in the ignore but still in the repository Git will let you track changes to it.
There was a problem hiding this comment.
The hash value is provided to see if the locally deployed FilesLauncher.exe needs to be updated.
If the hash is not correct, FilesLauncher.exe will not be properly updated.
#11750
yaira2
changed the title
Files.App.Launcher.exe.sha256Files.App.Launcher.exe.sha256
Correctly ignores the
Files.App.Launcher.exe.sha256file that was not correctly ignored previously.