Skip to content

Fix: Fixed pinned network computers not showing an icon in the sidebar #18901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brilliantkid87 wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

Fix: Fixed pinned network computers not showing an icon in the sidebar #18901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/Files.App/Data/Models/PinnedFoldersManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,16 @@ private async Task LoadIconForLocationItemAsync(LocationItem locationItem, strin
isFolder,
IconOptions.ReturnIconOnly);

// Shell icon APIs cannot resolve icons for bare network machine roots (e.g. "\\server"); fall back to the sidebar resource icons like DriveItem does.
if (result is null)
{
var isMachineRoot = path.StartsWith(@"\\", StringComparison.Ordinal) &&
path.Split('\\', StringSplitOptions.RemoveEmptyEntries).Length == 1;
result = UIHelpers.GetSidebarIconResourceInfo(isMachineRoot
? Constants.ImageRes.Network
: Constants.ImageRes.Folder)?.IconData;
}

locationItem.IconData = result;

// Assign Icon on the UI thread: it raises PropertyChanged, which builds a XAML IconElement in a realized SidebarItem.
Expand Down