Adding copyright free real world example before switching to html-parse #114
Conversation
| measureMemory :: T.Text -> IO () | ||
| measureMemory t = do | ||
| m <- measure (nf (scrapeStringLike t) (texts "h2")) 1 | ||
| let pma = (show . measPeakMbAllocated . fst) m |
There was a problem hiding this comment.
Looks like this was introduced in criterion 1.6.
Could you try adding that to extra-deps in stack.yaml? If that doesn't work let's just submit as is and I'll fiddle with the github actions to exclude benchmarks on older resolvers.
There was a problem hiding this comment.
measPeakMbAllocated as well as measure come with criterion-measurement: https://hackage.haskell.org/package/criterion-measurement-0.2.3.0/docs/Criterion-Measurement-Types.html
I've already added that under scalpel-core.cabal bench section
Did I miss something? Let me know if…
There was a problem hiding this comment.
The CI is failing on older stack resolvers that have a version of criterion-measurement before measPeakMbAllocated was introduced.
I think you can fix those by adding an extra-dep with a more recent version, e.g. 0.2.3.0, similar to here (I don't think the sha is actually necessary).
scalpel-core/benchmarks/Main.hs
Outdated
| let nested10000 = makeNested 10000 | ||
| -- permalink: https://en.wikipedia.org/w/index.php?title=New_York_City&oldid=1292263955 | ||
| wikipediaArticle <- T.readFile "benchmarks/wikipedia-new-york-city.html" | ||
| -- statsEnabled <- getGCStatsEnabled |
There was a problem hiding this comment.
Removed leftover; I left the source location of the file on purpose.
2 participants
(let me know if you'd prefer to load the html on test run instead of including it as file within the repo)