Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused DocumentsDirectoryAttributesProviding protocol #53

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions FingerprintJS.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
6A2048022971AD19008EC677 /* RawPointerConvertible.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6A47E06E296CA9EC00717C22 /* RawPointerConvertible.swift */; };
6A2048032971AD19008EC677 /* KernelSubsystem.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6A47E069296CA9E300717C22 /* KernelSubsystem.swift */; };
6A2048042971AD19008EC677 /* VirtualMemorySubsystem.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6A47E068296CA9E300717C22 /* VirtualMemorySubsystem.swift */; };
6A23866328042DFB002D09F3 /* DocumentsDirectoryAttributesProvidingMock.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6A23866228042DFB002D09F3 /* DocumentsDirectoryAttributesProvidingMock.swift */; };
6A2E484A29630DB200753ACD /* IdentifierStorableSpy.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6A2E484929630DB200753ACD /* IdentifierStorableSpy.swift */; };
6A2E484E2963355B00753ACD /* VendorIdentifierProviding.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6A2E484D2963355B00753ACD /* VendorIdentifierProviding.swift */; };
6A2E4850296336AC00753ACD /* VendorIdentifierProvidingSpy.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6A2E484F296336AC00753ACD /* VendorIdentifierProvidingSpy.swift */; };
Expand Down Expand Up @@ -78,7 +77,6 @@
6AB7146427EB65B1004BBCF3 /* MockHashingFunction.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6AB7146327EB65B1004BBCF3 /* MockHashingFunction.swift */; };
6AC03F4B27DE574100EF9DB7 /* DeviceInfoItem.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6AC03F4A27DE574100EF9DB7 /* DeviceInfoItem.swift */; };
6AC362AB280013E200C4768A /* HardwareInfoHarvesterTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6AC362AA280013E200C4768A /* HardwareInfoHarvesterTests.swift */; };
6AC362AE28001E7D00C4768A /* FileManager+DocumentsDirectoryAttributesProviding.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6AC362AD28001E7D00C4768A /* FileManager+DocumentsDirectoryAttributesProviding.swift */; };
6AC362B228042B7C00C4768A /* SystemControlMock.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6AC362B128042B7C00C4768A /* SystemControlMock.swift */; };
6AC362B628042C1500C4768A /* CPUInfoProvidingMock.swift in Sources */ = {isa = PBXBuildFile; fileRef = 6AC362B528042C1500C4768A /* CPUInfoProvidingMock.swift */; };
/* End PBXBuildFile section */
Expand Down Expand Up @@ -141,7 +139,6 @@
6A1D11402809DBDE00566F75 /* DeviceInfo.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DeviceInfo.swift; sourceTree = "<group>"; };
6A1D1142280F1B6600566F75 /* DeviceInfoProvider.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DeviceInfoProvider.swift; sourceTree = "<group>"; };
6A2047F32971ACFA008EC677 /* SystemControl.framework */ = {isa = PBXFileReference; explicitFileType = wrapper.framework; includeInIndex = 0; path = SystemControl.framework; sourceTree = BUILT_PRODUCTS_DIR; };
6A23866228042DFB002D09F3 /* DocumentsDirectoryAttributesProvidingMock.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DocumentsDirectoryAttributesProvidingMock.swift; sourceTree = "<group>"; };
6A2E484929630DB200753ACD /* IdentifierStorableSpy.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = IdentifierStorableSpy.swift; sourceTree = "<group>"; };
6A2E484D2963355B00753ACD /* VendorIdentifierProviding.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VendorIdentifierProviding.swift; sourceTree = "<group>"; };
6A2E484F296336AC00753ACD /* VendorIdentifierProvidingSpy.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VendorIdentifierProvidingSpy.swift; sourceTree = "<group>"; };
Expand Down Expand Up @@ -183,7 +180,6 @@
6AB7146327EB65B1004BBCF3 /* MockHashingFunction.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MockHashingFunction.swift; sourceTree = "<group>"; };
6AC03F4A27DE574100EF9DB7 /* DeviceInfoItem.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = DeviceInfoItem.swift; sourceTree = "<group>"; };
6AC362AA280013E200C4768A /* HardwareInfoHarvesterTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = HardwareInfoHarvesterTests.swift; sourceTree = "<group>"; };
6AC362AD28001E7D00C4768A /* FileManager+DocumentsDirectoryAttributesProviding.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "FileManager+DocumentsDirectoryAttributesProviding.swift"; sourceTree = "<group>"; };
6AC362B128042B7C00C4768A /* SystemControlMock.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SystemControlMock.swift; sourceTree = "<group>"; };
6AC362B528042C1500C4768A /* CPUInfoProvidingMock.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CPUInfoProvidingMock.swift; sourceTree = "<group>"; };
/* End PBXFileReference section */
Expand Down Expand Up @@ -470,7 +466,6 @@
children = (
6A9B7CB527E7AC55002B9939 /* CGSize+CustomStringConvertible.swift */,
6AC03F4A27DE574100EF9DB7 /* DeviceInfoItem.swift */,
6AC362AD28001E7D00C4768A /* FileManager+DocumentsDirectoryAttributesProviding.swift */,
6A82A19627D74D5B007C023F /* Fingerprintable.swift */,
6A82A1A727D89CB0007C023F /* Storage */,
);
Expand Down Expand Up @@ -551,7 +546,6 @@
isa = PBXGroup;
children = (
6AC362B528042C1500C4768A /* CPUInfoProvidingMock.swift */,
6A23866228042DFB002D09F3 /* DocumentsDirectoryAttributesProvidingMock.swift */,
6AB7146327EB65B1004BBCF3 /* MockHashingFunction.swift */,
6AC362B128042B7C00C4768A /* SystemControlMock.swift */,
);
Expand Down Expand Up @@ -796,7 +790,6 @@
6A9B7CB427E7AB6D002B9939 /* FingerprintFunction.swift in Sources */,
159E0BB2292D18B800E2C38A /* UserInterfaceTraitsProviding.swift in Sources */,
6A9B7CB827E7ADC8002B9939 /* FingerprintTree.swift in Sources */,
6AC362AE28001E7D00C4768A /* FileManager+DocumentsDirectoryAttributesProviding.swift in Sources */,
15D7C62A294A6B010025CE74 /* FingerprintStabilityLevel.swift in Sources */,
6A82A1B327DB5941007C023F /* OSInfoHarvester.swift in Sources */,
159E0BD32940D35B00E2C38A /* CellularNetworkInfoHarvester.swift in Sources */,
Expand Down Expand Up @@ -840,7 +833,6 @@
6AC362B228042B7C00C4768A /* SystemControlMock.swift in Sources */,
159E0BAE292D149700E2C38A /* AppInfoHarvesterTests.swift in Sources */,
159E0BDD294108E900E2C38A /* CarrierInfoProvidingSpy.swift in Sources */,
6A23866328042DFB002D09F3 /* DocumentsDirectoryAttributesProvidingMock.swift in Sources */,
159E0BC5293E4FF900E2C38A /* LocaleInfoProvidingSpy.swift in Sources */,
6AB7146127EB612D004BBCF3 /* FingerprintTreeCalculatorTests.swift in Sources */,
15D7C657298C07220025CE74 /* LocalAuthenticationInfoHarvesterTests.swift in Sources */,
Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -34,20 +34,17 @@ struct HardwareInfoHarvester {
private let device: DeviceIdentificationInfoProviding
private let screen: ScreenInfoProviding
private let systemControl: SystemControlValuesProviding
private let fileManager: DocumentsDirectoryAttributesProviding
private let processInfo: CPUInfoProviding

init(
device: DeviceIdentificationInfoProviding,
screen: ScreenInfoProviding,
systemControl: SystemControlValuesProviding,
fileManager: DocumentsDirectoryAttributesProviding,
processInfo: CPUInfoProviding
) {
self.device = device
self.screen = screen
self.systemControl = systemControl
self.fileManager = fileManager
self.processInfo = processInfo
}

Expand All @@ -56,7 +53,6 @@ struct HardwareInfoHarvester {
device: UIDevice.current,
screen: UIScreen.main,
systemControl: SystemControlValuesProvider(),
fileManager: FileManager.default,
processInfo: ProcessInfo.processInfo
)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,29 +8,25 @@ final class HardwareInfoHarvesterTests: XCTestCase {
private var screenInfoProviderSpy: ScreenInfoProvidingSpy!
private var deviceIdentificationInfoProviderSpy: DeviceIdentificationInfoProvidingSpy!
private var mockSystemControl: SystemControlMock!
private var mockDocumentDirectoryAttributesProvider: DocumentsDirectoryAttributesProvidingMock!
private var mockCpuInfoProvider: CPUInfoProvidingMock!

override func setUp() {
super.setUp()
screenInfoProviderSpy = .init()
deviceIdentificationInfoProviderSpy = .init()
mockSystemControl = .init()
mockDocumentDirectoryAttributesProvider = .init()
mockCpuInfoProvider = .init()
sut = HardwareInfoHarvester(
device: deviceIdentificationInfoProviderSpy,
screen: screenInfoProviderSpy,
systemControl: mockSystemControl,
fileManager: mockDocumentDirectoryAttributesProvider,
processInfo: mockCpuInfoProvider
)
}

override func tearDown() {
sut = nil
mockCpuInfoProvider = nil
mockDocumentDirectoryAttributesProvider = nil
mockSystemControl = nil
deviceIdentificationInfoProviderSpy = nil
screenInfoProviderSpy = nil
Expand Down

This file was deleted.

Loading