Reorder elements in EmptyView #1397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, there are more uses of this view, from a quick search various places related to AdIn Primarily it would be good if you can check on the smallest screen size we support, to make sure it looks good there as well (text visible on screen for instance 😅) |
|
Closing this PR. We’ve decided to stick with the old design on iOS for now and discuss it further later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
To improve the visual hierarchy and user experience, the image in the EmptyView should be placed above the title and description. This change will also align iOS with Web and Android.
What?
Would this change affect other parts of the app? Please review and let me know if need adjustments.
UI Changes