Rename EmptyView to LegacyEmptyView to avoid SwiftUI.EmptyView ambiguity - #1451
Merged
Conversation
AndreyMomot
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
FinniversKit's public (already deprecated)
EmptyViewshadowedSwiftUI.EmptyView. Any file importing both modules had to disambiguate with explicitFinniversKit.EmptyView/SwiftUI.EmptyViewqualifiers. Renaming removes the name collision.What?
Renamed the type and its companions:
EmptyView→LegacyEmptyViewEmptyViewDelegate→LegacyEmptyViewDelegateEmptyViewShapeType→LegacyEmptyViewShapeTypeDeprecated
typealiasdeclarations for the old names are kept for source compatibility, so downstream consumers won't break. Internal usages (GenericErrorSwiftUIView, demo view,Xcode project file reference) updated to the new name. The source file was renamed
EmptyView.swift→LegacyEmptyView.swift.Note: because the deprecated typealias keeps the old name in the module, the ambiguity with
SwiftUI.EmptyViewis only fully removed once consumers migrate offEmptyView. Happyto drop the typealias for a hard break if preferred.
Version Change
Minor — non-breaking, additive deprecations only.
UI Changes
None. No visual or behavioral changes.