fix(ui_auth): Fix EmailVerificationController lifecycle #462
Conversation
Before this change, EmailVerificationController created during email verification workflow remained active on the background. When user signed out within the same session, FurebaseAuth.currentUser become null and the controller accessed it assuming it's never null. After the change, controller is disposed after leaving the verification screen.
…s disposed. When EmailVerificationController is no longer needed, it's disposed. However, sendVerificationEmail might still be running after disposal because it's async. It updates ValueNotifier's value, which throws an exception when called after dispose. This change prevents that by terminating sendVerificationEmail early when its result is no longer needed.
karelklic
changed the title
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
The fix is still valid. We use it, and it works. |
github-actions
bot
added
Needs Attention
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
Even after two months, the fix is still valid. Awaiting feedback from the maintainer. |
|
Hello 👋, this PR has been opened for more than 2 months with no activity on it. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 15 days until this gets closed automatically |
|
The fix is still valid. |
Description
Fix EmailVerificationController lifecycle.
Before the change, each visit to
EmailVerificationScreencreates a new controller that is kept indefinitely in the background and updated on the app resume. SinceEmailVerificationControllerassumes that a user is logged in, these controller instances throw an exception when user logs out and app resume event is called.After this change, a
EmailVerificationControlleris disposed when no longer needed by a screen that created it. If controller'ssendVerificationEmailasync method is still running during dispose, it is terminated early.Related Issues
Fixes #9
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.melos run test:unit:alldoesn't fail).Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?