Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_ui_auth): Catch sms code validation #482

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wer-mathurin
Copy link

@wer-mathurin wer-mathurin commented Mar 14, 2025

Description

This allow the user to pass an onError function when an error happen when validating the sms code

Related Issues

#481

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@wer-mathurin
Copy link
Author

@russellwheatley
just a working example of what need to be accomplish.

But the way I've done it may need refactoring. Affecting a completer more than once does not smell well...
Since I'm not familiar with this package, Who can help me with this?

This is a breaking change since the Completer must return a nullable value.

@wer-mathurin wer-mathurin changed the title WIP - #481 fix(firebase_ui_auth): FIX #481 Mar 14, 2025
@wer-mathurin wer-mathurin changed the title fix(firebase_ui_auth): FIX #481 fix(firebase_ui_auth): Catch sms code validation Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant