Repository navigation
Description
Tracks parity between the storage-resize-images extension (0.3.6) and the @firebase-function-kits/storage-resize-images kit.
How it was tested: both deployed side by side on a test project with matching configs and driven with the same uploads, then compared on output images, metadata, paths, deletes, events, content filtering, logs, regions, install, reconfigure and uninstall. Kit tested at 0.0.2-rc.7 (kits @ fcdd555), installed with functions:kits:install. ext:migrate and the interactive install prompts are not covered yet.
Resize output, metadata, paths, include and exclude lists, delete modes, bad-input handling and loop guards matched the extension in every case tested.
Also affects this kit: #3168 (unknown IMAGE_TYPE values).
Existing extension bugs that the kit carries over are tracked separately, not as sub-issues: #3269 (a malformed reply to CUSTOM_FILTER_PROMPT blocks the image) and #3270 (content filter failures in a region without the model don't name the region).
Sub-issues are ordered by priority, highest first.
Issues labelled decision need a call: change the kit, or record the difference as accepted in the below "Decisions" section.
Decisions
- decision(storage-resize-images): kit/extension parity – CLI-installed kit runs Node 24, extension runs Node 22 #3328: the runtime follows the host codebase, so
functions:kits:installwrites Node 24 where the extension ran nodejs22. Accepted. Not checked on the deployed function. - decision(storage-resize-images): kit/extension parity – kit continues after an Eventarc publish failure, the extension aborts #3329: Eventarc publish failures are logged as warnings and resizing carries on, where a failed
onStartpublish stopped the extension's resize. Accepted. Documented in docs(storage-resize-images): note that a failed event publish doesn't stop resizing #3323. - decision(storage-resize-images): kit/extension parity – blank required params fail the kit deploy, the extension uses defaults #3327: blank required params fail the deploy instead of falling back to their defaults, as the
firestore-bigquery-exportkit does. Accepted. README update in docs(storage-resize-images): mark which kit settings can be blank #3320. - decision(storage-resize-images): kit/extension parity – event source is per function, not per instance #3272: events keep the per-function
source(…/services/kit-<id>-generateResizedImage) instead of the extension's per-instance one. Accepted. README update in docs(storage-resize-images): document the kit's event source #3306. - decision(storage-resize-images): kit/extension parity – ALLOWED_EVENT_TYPES is ignored, the kit reads EXT_SELECTED_EVENTS #3273: the kit reads
EXT_SELECTED_EVENTSand ignoresALLOWED_EVENT_TYPES, as thefirestore-bigquery-exportkit does. Accepted. README update in docs(storage-resize-images): document EXT_SELECTED_EVENTS #3285. - decision(storage-resize-images): kit/extension parity – FUNCTION_DEFAULT_REGION is required but BUCKET_REGION overrides it #3274:
FUNCTION_DEFAULT_REGIONis required but only used whenBUCKET_REGIONis empty, as thefirestore-bigquery-exportkit does withDATABASE_REGION. Accepted. README update in docs(storage-resize-images): document FUNCTION_DEFAULT_REGION #3307.
Intentional Differences
- Eventarc publish failures: logged as warnings, and resizing carries on. The extension's awaited
onStartpublish failed the run before resizing. Seen in the code, not tested live (decision(storage-resize-images): kit/extension parity – kit continues after an Eventarc publish failure, the extension aborts #3329). - Node runtime: follows the host codebase.
functions:kits:installwrites Node 24; the extension ran nodejs22. Not checked on the deployed function (decision(storage-resize-images): kit/extension parity – CLI-installed kit runs Node 24, extension runs Node 22 #3328).
Activity
docs(storage-resize-images): note that a failed event publish doesn't…