Skip to content

Comments

fix: Pass through BigQuery Config in multithreaded worker (closes #2298)#2299

Closed
justin-plancraft wants to merge 2 commits intofirebase:nextfrom
justin-plancraft:@justin-plancraft/fix-multi-project-multi-threaded-import
Closed

fix: Pass through BigQuery Config in multithreaded worker (closes #2298)#2299
justin-plancraft wants to merge 2 commits intofirebase:nextfrom
justin-plancraft:@justin-plancraft/fix-multi-project-multi-threaded-import

Conversation

@justin-plancraft
Copy link

This closes #2298 by passing through the bqProjectConfig :)

@google-cla
Copy link

google-cla bot commented Feb 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@cabljac cabljac self-assigned this Feb 28, 2025
@cabljac
Copy link
Contributor

cabljac commented Feb 28, 2025

Hi, thanks for the contribution! I'll review and try to get this out ASAP

Copy link
Contributor

@cabljac cabljac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cabljac
Copy link
Contributor

cabljac commented Feb 28, 2025

I'm just going to run some end to end tests on it, then i'll push a release.

@cabljac
Copy link
Contributor

cabljac commented May 8, 2025

Closing as this is resolved in the latest version of the script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [fs-bq-import-collection] Multi-Threaded import Script does not Support Cross-Project loading

2 participants