Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the README.md for the firestore-send-email kit to document a change in how the CloudEvent source is identified. The feedback suggests separating this new information into its own distinct section with a dedicated heading rather than combining it with the Eventarc channel creation section, which improves readability and scanability.
This was referenced Nov 10, 2026
…event-source # Conflicts: # kits/firestore-send-email/README.md
cabljac
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3298.
A trigger that filters on the extension's event
sourcestops receiving events after moving to the kit, with no error.This documents the new
sourcevalue next to the Eventarc channel note under the differences from the extension, the same way thedelete-user-datakit does.delete-user-data(decision(delete-user-data): kit/extension parity – event source is per function, not per instance #3255) and recorded infirestore-send-emailkit tracking issue #3290.