Skip to content

docs(firestore-send-email): document that the kit's event source has changed - #3309

Open
CorieW wants to merge 3 commits into
kitsfrom
docs/kits-send-email-event-source
Open

CorieW wants to merge 3 commits into
kitsfrom
docs/kits-send-email-event-source

Conversation

@CorieW

@CorieW CorieW commented Nov 3, 2026

Copy link
Copy Markdown
Member

Fixes #3298.

A trigger that filters on the extension's event source stops receiving events after moving to the kit, with no error.

This documents the new source value next to the Eventarc channel note under the differences from the extension, the same way the delete-user-data kit does.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md for the firestore-send-email kit to document a change in how the CloudEvent source is identified. The feedback suggests separating this new information into its own distinct section with a dedicated heading rather than combining it with the Eventarc channel creation section, which improves readability and scanability.

Comment thread kits/firestore-send-email/README.md Resolved
Comment thread kits/firestore-send-email/README.md Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

decision(firestore-send-email): kit/extension parity – event source is per function, not per instance

2 participants