Skip to content

fix(delete-user-data): derive the Pub/Sub topic names from the instance id - #3330

Open
CorieW wants to merge 2 commits into
kitsfrom
fix/delete-user-data-topic-names
Open

CorieW wants to merge 2 commits into
kitsfrom
fix/delete-user-data-topic-names

Conversation

@CorieW

@CorieW CorieW commented Nov 16, 2026

Copy link
Copy Markdown
Member

Fixes #3260. Part of #3249.

The kit had two settings the extension never had, DISCOVERY_TOPIC_NAME and DELETION_TOPIC_NAME. ext:migrate has no value to write for them, so a non-interactive migration failed and rolled back, and an interactive one stopped to ask for both names.

This removes both settings. The triggers now always use kit-<instance id>-discovery and kit-<instance id>-deletion, as the extension named its topics from its instance id with no setting to change them.

Before After
ext:migrate --non-interactive fails: no value for the following environment variables: DISCOVERY_TOPIC_NAME, DELETION_TOPIC_NAME no topic settings to fill
Interactive ext:migrate asks for both topic names doesn't ask
Topic names kit-<instance id>-* unless overridden always kit-<instance id>-*
  • Why the settings existed: the kit was ported before the CLI told kits their instance id, so the topic names had to be settings. Since firebase-tools 15.27.0 the CLI provides FIREBASE_KIT_INSTANCE_ID during deploy (fix(delete-user-data): read the kit instance id from FIREBASE_KIT_INSTANCE_ID #3060), which the kit already used for the topic defaults.
  • Breaking for anyone who set either one: the value is now ignored and the functions move to the kit-<instance id>-* topics on the next deploy. DeleteUserDataConfig no longer takes discoveryTopicName or deletionTopicName. Both are in the CHANGELOG.

Tests (190) and tsc -b pass. Not deployed, and ext:migrate not re-run.

…ce id

Removes the kit-only `DISCOVERY_TOPIC_NAME` and `DELETION_TOPIC_NAME`
params. The triggers now always use `kit-<instance id>-discovery` and
`kit-<instance id>-deletion`, as the extension named its topics from its
instance id with no setting to change them. Fixes #3260. Part of #3249.

`ext:migrate` has no value to write for a param the extension never had,
so a non-interactive migration failed and rolled back, and an
interactive one stopped to ask for both names.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the DISCOVERY_TOPIC_NAME and DELETION_TOPIC_NAME configuration parameters from the delete-user-data kit. Instead, the Pub/Sub topic names are now strictly derived from the kit's instance ID (e.g., kit-<instance id>-discovery and kit-<instance id>-deletion). This aligns the kit's behavior with the original extension and prevents non-interactive migrations (firebase ext:migrate --non-interactive) from failing due to missing values for these parameters. Relevant documentation, configuration logic, and tests have been updated accordingly. I have no feedback to provide as there are no review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant