Repository navigation
Conversation
…ce id Removes the kit-only `DISCOVERY_TOPIC_NAME` and `DELETION_TOPIC_NAME` params. The triggers now always use `kit-<instance id>-discovery` and `kit-<instance id>-deletion`, as the extension named its topics from its instance id with no setting to change them. Fixes #3260. Part of #3249. `ext:migrate` has no value to write for a param the extension never had, so a non-interactive migration failed and rolled back, and an interactive one stopped to ask for both names.
This was referenced Nov 16, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the DISCOVERY_TOPIC_NAME and DELETION_TOPIC_NAME configuration parameters from the delete-user-data kit. Instead, the Pub/Sub topic names are now strictly derived from the kit's instance ID (e.g., kit-<instance id>-discovery and kit-<instance id>-deletion). This aligns the kit's behavior with the original extension and prevents non-interactive migrations (firebase ext:migrate --non-interactive) from failing due to missing values for these parameters. Relevant documentation, configuration logic, and tests have been updated accordingly. I have no feedback to provide as there are no review comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3260. Part of #3249.
The kit had two settings the extension never had,
DISCOVERY_TOPIC_NAMEandDELETION_TOPIC_NAME.ext:migratehas no value to write for them, so a non-interactive migration failed and rolled back, and an interactive one stopped to ask for both names.This removes both settings. The triggers now always use
kit-<instance id>-discoveryandkit-<instance id>-deletion, as the extension named its topics from its instance id with no setting to change them.ext:migrate --non-interactiveno value for the following environment variables: DISCOVERY_TOPIC_NAME, DELETION_TOPIC_NAMEext:migratekit-<instance id>-*unless overriddenkit-<instance id>-*FIREBASE_KIT_INSTANCE_IDduring deploy (fix(delete-user-data): read the kit instance id from FIREBASE_KIT_INSTANCE_ID #3060), which the kit already used for the topic defaults.kit-<instance id>-*topics on the next deploy.DeleteUserDataConfigno longer takesdiscoveryTopicNameordeletionTopicName. Both are in the CHANGELOG.Tests (190) and
tsc -bpass. Not deployed, andext:migratenot re-run.