Skip to content

Fix (#688): Updated JSON tag for ChannelID field in AndroidConfig.Notification #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Surya-7890
Copy link

In the try it out example in , we can see that the channelId field in android.notification is in camel case,

{
  message: {
      android: {
          notification: {
              channelId: ""
          }
      }
  }
}

While in the SDK, the json tag for that field is set to the following

ype AndroidNotification struct {
        // ... other fields
	ChannelID             string                        `json:"channel_id,omitempty"`
}

FIx:
Modified the occurances of this fields

ChannelID string `json:"channel_id,omitempty"`

and

"channel_id": "channel",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant