dataconnect: Improve usage of MutableStateFlow to improve readability

[dconeybe]

Use MutableStateFlow.update() instead of MutableStateFlow.compareAndSet() directly for improved readability and less potential for bugs

[google-oss-bot]

Coverage Report ¹

Affected Products

• firebase-dataconnect

  Overall coverage changed from 14.45% (e98dd2c) to 14.31% (2b86ff6) by -0.15%.

  Filename	Base (e98dd2c)	Merge (2b86ff6)	Diff
  DataConnectCredentialsTokenManager.kt	34.12%	30.77%	-3.35%
  FirebaseDataConnectImpl.kt	42.34%	43.05%	+0.71%

Test Logs

• Base (e98dd2c): https://github.com/firebase/firebase-android-sdk/actions/runs/14495866323
• Merge (2b86ff6): https://github.com/firebase/firebase-android-sdk/actions/runs/14500294559

1. https://storage.googleapis.com/firebase-sdk-metric-reports/jMY06g0QSv.html

[github-actions]

Test Results

   66 files   -    968     66 suites   - 968   1m 19s ⏱️ - 33m 16s
  552 tests  -  5 322    551 ✅  -  5 301  1 💤  - 21  0 ❌ ±0 
1 104 runs   - 10 707  1 102 ✅  - 10 665  2 💤  - 42  0 ❌ ±0 

Results for commit b1f01b0. ± Comparison against base commit e98dd2c.

This pull request removes 5322 tests.

com.google.android.datatransport.cct.CctBackendFactoryTest ‑ create_returnCCTBackend_WhenBackendNameIsCCT
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldOnlySupportProtoAndJson
com.google.android.datatransport.cct.CctDestinationTest ‑ cctDestination_shouldSupportProtoAndJson
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOffline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ decorate_whenOnline_shouldProperlyPopulateNetworkInfo
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldAddCookieOnPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ schedule_shouldDropCookieOnMixedPseudonymousIds
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_CompressedResponseIsUncompressed
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirectsMoreThan5Times_shouldOnlyRedirect4Times
com.google.android.datatransport.cct.CctTransportBackendTest ‑ send_whenBackendRedirects_shouldCorrectlyFollowTheRedirectViaPost
…

♻️ This comment has been updated with latest results.

[google-oss-bot]

Size Report ¹

Affected Products

• firebase-dataconnect

  Type	Base (e98dd2c)	Merge (2b86ff6)	Diff
  aar	709 kB	710 kB	+835 B (+0.1%)
  apk (release)	10.0 MB	10.0 MB	+832 B (+0.0%)

Test Logs

• Base (e98dd2c): https://github.com/firebase/firebase-android-sdk/actions/runs/14495866323
• Merge (2b86ff6): https://github.com/firebase/firebase-android-sdk/actions/runs/14500294559

1. https://storage.googleapis.com/firebase-sdk-metric-reports/0Z8vglpmOn.html

[github-actions]

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

[github-actions]

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

[Copilot]

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/DataConnectCredentialsTokenManager.kt:196

• [nitpick] Consider renaming the lambda parameter 'oldState' to 'currentState' in the forceRefresh function for improved clarity, as it represents the prior state before the update.

state.getAndUpdate { oldState ->

firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/DataConnectCredentialsTokenManager.kt:343

• [nitpick] Consider renaming the lambda parameter 'oldState' to 'currentState' in the onProviderAvailable function for consistency and clearer indication that it represents the pre-update state.

state.getAndUpdate { oldState ->

[Copilot]

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/DataConnectCredentialsTokenManager.kt:195

• In forceRefresh(), the previous implementation checked that the new state had forceTokenRefresh set to true. Please verify that the removal of this explicit check in the getAndUpdate update block does not allow for unexpected state transitions.

val oldState = state.getAndUpdate { currentState ->

firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/DataConnectCredentialsTokenManager.kt:342

• In onProviderAvailable(), the CAS loop is replaced with a getAndUpdate call that always returns the old state. Confirm that this change still satisfies the intended concurrency and state transition guarantees.

val oldState = state.getAndUpdate { currentState ->

[Copilot]

Pull Request Overview

This PR enhances readability and reduces the potential for bugs by replacing explicit CAS loops with the more concise and expressive MutableStateFlow update helpers. Key changes include:

• Replacing while loops using compareAndSet with update(), updateAndGet(), and getAndUpdate().
• Simplifying asynchronous state management in the close job and token management flows.
• Improving clarity of state transitions in multiple components.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
firebase-dataconnect/testutil/src/main/kotlin/com/google/firebase/dataconnect/testutil/SuspendingCountDownLatch.kt	Replaced CAS loop with update() for decrementing the count.
firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/querymgr/RegisteredDataDeserialzer.kt	Replaced CAS loop with update() for atomically setting the latest update.
firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/QuerySubscriptionImpl.kt	Replaced CAS loop with update() to safely update the last result.
firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/FirebaseDataConnectImpl.kt	Replaced CAS loop with updateAndGet() to manage the close job state more robustly.
firebase-dataconnect/src/main/kotlin/com/google/firebase/dataconnect/core/DataConnectCredentialsTokenManager.kt	Replaced CAS loops with getAndUpdate() to handle state transitions during close, force refresh, and token provider updates.