Skip to content

fix(ci): raise mocha timeout for the integration suite - #338

Open
IzaakGough wants to merge 1 commit into
masterfrom
@invertase/fix-integration-test-timeout
Open

IzaakGough wants to merge 1 commit into
masterfrom
@invertase/fix-integration-test-timeout

Conversation

@IzaakGough

@IzaakGough IzaakGough commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor
  • Run the integration suite with a 20s mocha timeout. The Firestore test starts writing less than a second after the emulator comes up, and on a slow runner that first round trip crosses mocha's 2000ms default, so the job fails on timing rather than on anything in the change under test.
  • Left the unit suite on the default. It has no external process to wait on, and a low timeout there is still useful.

Same commit passing on one run and timing out on another is what prompted this: run 36005088606 (push) went green while 36005116781 attempt 1 (pull_request) failed on Timeout of 2000ms exceeded. Verified locally that the suite passes with the flag, and that a deliberate 3s test fails without it and passes with it.

The Firestore integration test runs against an emulator that has just
started, and the first round trip can exceed mocha's 2000ms default on a
slow runner, failing the job on timing alone. Run the integration suite
with a 20s timeout.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the integrationTest script in package.json to include a 20-second timeout (--timeout 20000) for the Mocha integration tests. There are no review comments, and I have no feedback to provide.

@IzaakGough
IzaakGough marked this pull request as ready for review September 25, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants