Skip to content

Conversation

colerogers
Copy link
Contributor

@colerogers colerogers commented Apr 20, 2022

Addresses #1078

@colerogers colerogers requested review from inlined and taeold April 20, 2022 18:53
Copy link
Member

@inlined inlined left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the bug we're trying to work around with this min version bump?

FWIW, the functions framework dependencies list the typings for 4.17.13 but the actual dependency is a whole minor less; ^4.16.4. I wonder if we should have ever bumped to 4.17.x since FF supports 4.16.

@inlined
Copy link
Member

inlined commented Jun 3, 2022

Ping

@colerogers
Copy link
Contributor Author

colerogers commented Jun 7, 2022

@inlined This was just a request to bump the version to get rid of dependency warnings -- #1078

We can remove this and downgrade if you recommend that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants