Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VQ exploration #13448

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

VQ exploration #13448

wants to merge 30 commits into from

Conversation

MarkDuckworth
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

@google-oss-bot
Copy link

google-oss-bot commented Aug 2, 2024

2 Warnings
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)
⚠️ New public headers were added, did you remember to add them to the umbrella header?

Generated by 🚫 Danger

Copy link
Contributor

github-actions bot commented Aug 2, 2024

Apple API Diff Report

Commit: a7b8ef7
Last updated: Thu Aug 8 15:11 PDT 2024
View workflow logs & download artifacts


[BUILD ERROR] FirebaseFirestoreInternal


[BUILD ERROR] FirebaseFirestore


@ncooke3 ncooke3 self-assigned this Aug 2, 2024
Base automatically changed from markduckworth/vector-type to main August 12, 2024 13:39

NS_ASSUME_NONNULL_BEGIN

NS_SWIFT_NAME(VectorQuery)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants