Adding Integration Test for Phone Number Authentication in Firebase #13527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragatimodi
reviewed
Aug 21, 2024
| @@ -0,0 +1,56 @@ | |||
| // | |||
There was a problem hiding this comment.
Please add Google copyrights
You can refer to https://github.com/firebase/firebase-ios-sdk/blob/main/FirebaseAuth/Tests/SampleSwift/SwiftApiTests/PhoneMultiFactorTests.swift or other files in the repo
|
FYI, CI for the auth integration tests only run for PRs from a branch in the main firebase-ios-sdk repo in order to access the needed credentials. |
pragatimodi
reviewed
Aug 23, 2024
| @@ -0,0 +1,66 @@ | |||
| /* | |||
| * Copyright 2019 Google | |||
There was a problem hiding this comment.
Suggested change
| * Copyright 2019 Google | |
| * Copyright 2024 Google |
|
Replaced by #13538 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement integration test for verifying phone number sign-in with Firebase Auth. Please review and approve.