Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ppl API #14513

Open
wants to merge 24 commits into
base: cheryllin/ppl
Choose a base branch
from
Open

Ppl API #14513

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ FirebaseAppCheck/Apps/AppCheckCustomProvideApp/AppCheckCustomProvideApp/GoogleSe
/Example/FirestoreSample/ui-debug.log
/Example/FirestoreSample/firestore-debug.log
/Example/FirestoreSample/firebase-debug.log
Firestore/Example/GoogleService-Info.plist

# generated Terraform docs
.terraform/*
Expand Down
124 changes: 66 additions & 58 deletions Firestore/Example/Firestore.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion Firestore/Example/Tests/Util/FSTIntegrationTestCase.mm
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
static const double kPrimingTimeout = 45.0;

static NSString *defaultProjectId;
static NSString *defaultDatabaseId = @"(default)";
static NSString *defaultDatabaseId = @"enterprise";
static FIRFirestoreSettings *defaultSettings;

static bool runningAgainstEmulator = false;
Expand Down
11 changes: 9 additions & 2 deletions Firestore/Source/API/FIRPipelineBridge+Internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#include <memory>

#include "Firestore/core/src/api/expressions.h"
#include "Firestore/core/src/api/firestore.h"
#include "Firestore/core/src/api/pipeline.h"
#include "Firestore/core/src/api/stages.h"

Expand All @@ -30,13 +31,13 @@ NS_ASSUME_NONNULL_BEGIN

@interface FIRExprBridge (Internal)

- (std::shared_ptr<api::Expr>)cpp_expr;
- (std::shared_ptr<api::Expr>)cppExprWithReader:(FSTUserDataReader *)reader;

@end

@interface FIRStageBridge (Internal)

- (std::shared_ptr<api::Stage>)cpp_stage;
- (std::shared_ptr<api::Stage>)cppStageWithReader:(FSTUserDataReader *)reader;

@end

Expand All @@ -46,4 +47,10 @@ NS_ASSUME_NONNULL_BEGIN

@end

@interface __FIRPipelineResultBridge (Internal)

- (id)initWithCppResult:(api::PipelineResult)result db:(std::shared_ptr<api::Firestore>)db;

@end

NS_ASSUME_NONNULL_END
Loading