Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Migrate Storage CI to Xcode 16 #14657

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[Infra] Migrate Storage CI to Xcode 16 #14657

wants to merge 9 commits into from

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Apr 4, 2025

#no-changelog

Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

@@ -169,7 +166,7 @@ jobs:
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }}
LEGACY: true
runs-on: macos-14
runs-on: macos-15
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one caveat with this. the default xcode version on macos 15 is Xcode 16.0.

while it's not critical for source based builds, we could either:

  • explicitly set the Xcode version for all macos 15 jobs
  • only set it when needed (build uses binary built with Xcode 16.2)

@ncooke3
Copy link
Member Author

ncooke3 commented Apr 4, 2025

Interesting, looks like Xcode 16.3 didn't work:

Run sudo xcode-select -s /Applications/Xcode_16.3.app/Contents/Developer
  sudo xcode-select -s /Applications/Xcode_16.3.app/Contents/Developer
  shell: /bin/bash -e {0}
  env:
    PATH: /Users/runner/.local/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Users/runner/.cargo/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Library/Frameworks/Python.framework/Versions/Current/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools
xcode-select: error: invalid developer directory '/Applications/Xcode_16.3.app/Contents/Developer'

@paulb777
Copy link
Member

paulb777 commented Apr 9, 2025

Looks like a unit test problem on macOS 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants