-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Migrate Storage CI to Xcode 16 #14657
base: main
Are you sure you want to change the base?
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback. |
@@ -169,7 +166,7 @@ jobs: | |||
plist_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | |||
signin_secret: ${{ secrets.GHASecretsGPGPassphrase1 }} | |||
LEGACY: true | |||
runs-on: macos-14 | |||
runs-on: macos-15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one caveat with this. the default xcode version on macos 15 is Xcode 16.0.
while it's not critical for source based builds, we could either:
- explicitly set the Xcode version for all macos 15 jobs
- only set it when needed (build uses binary built with Xcode 16.2)
Interesting, looks like Xcode 16.3 didn't work:
|
This reverts commit 7300a26.
Looks like a unit test problem on macOS 14 |
#no-changelog