Skip to content

Implement AsyncStream to listen for remote config updates #14662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions FirebaseRemoteConfig/Swift/RemoteConfig+AsyncStream.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
// Copyright 2025 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

public extension RemoteConfig {
/// Asynchronous stream of configuration updates.
@available(iOS 13.0, macOS 10.15, macCatalyst 13.0, watchOS 7.0, tvOS 13.0, *)
var updateStream: AsyncStream<Result<RemoteConfigUpdate, Error>> {
AsyncStream { continuation in
let registration = self.addOnConfigUpdateListener { update, error in
if let error = error {
continuation.yield(.failure(error))
} else if let update {
continuation.yield(.success(update))
}
}
continuation.onTermination = { _ in
registration.remove()
}
}
}
}
25 changes: 25 additions & 0 deletions FirebaseRemoteConfig/Tests/Swift/SwiftAPI/APITests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,31 @@
registration.remove()
}

func testRealtimeRemoteConfigRealConsoleAsync() async {
guard APITests.useFakeConfig == false else { return }

let expectation = expectation(description: #function)

let task = Task {
for await updateResult in config.updateStream {
switch updateResult {
case let .success(update):
XCTAssertNotNil(update)
XCTAssertNotNil(update.updatedKeys.contains(Constants.jedi))
case let .failure(error):
XCTFail("Expected a successful update result, but received an error: \(error)")
}

expectation.fulfill()
}
}

console.updateRemoteConfigValue(Constants.yoda, forKey: Constants.jedi)

await fulfillment(of: [expectation], timeout: 5.0)
task.cancel()
}

// MARK: - RemoteConfigConsole Tests

func testFetchConfigThenUpdateConsoleThenFetchAgain() {
Expand Down Expand Up @@ -268,7 +293,7 @@

private func waitForExpectations() {
let kTestTimeout = 10.0
waitForExpectations(timeout: kTestTimeout,

Check failure on line 296 in FirebaseRemoteConfig/Tests/Swift/SwiftAPI/APITests.swift

View workflow job for this annotation

GitHub Actions / remoteconfig (iOS)

testUnchangedActivateWillFlag, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "testUnchangedActivateWillFlag()".

Check failure on line 296 in FirebaseRemoteConfig/Tests/Swift/SwiftAPI/APITests.swift

View workflow job for this annotation

GitHub Actions / remoteconfig (iOS)

testFetchWithExpirationThenActivate, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "testFetchWithExpirationThenActivate()".

Check failure on line 296 in FirebaseRemoteConfig/Tests/Swift/SwiftAPI/APITests.swift

View workflow job for this annotation

GitHub Actions / remoteconfig (iOS)

testFetchThenActivate, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "testFetchThenActivate()".

Check failure on line 296 in FirebaseRemoteConfig/Tests/Swift/SwiftAPI/APITests.swift

View workflow job for this annotation

GitHub Actions / remoteconfig (iOS)

testFetchAndActivate, Asynchronous wait failed: Exceeded timeout of 10 seconds, with unfulfilled expectations: "testFetchAndActivate()".
handler: { error in
if let error {
print(error)
Expand Down
Loading