Skip to content

Erikeldridge vertex api 2 #8929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 22 commits into from
Closed

Erikeldridge vertex api 2 #8929

wants to merge 22 commits into from

Conversation

gsiddh
Copy link

@gsiddh gsiddh commented Apr 15, 2025

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

gsiddh and others added 17 commits April 15, 2025 15:35
@gsiddh
Vaihi add langmodel types. (#8927)
8319ae9 
* Adding LanguageModel types. These are based off https://github.com/webmachinelearning/prompt-api?tab=readme-ov-file#full-api-surface-in-web-idl

* Adding LanguageModel types.

* Remove bunch of exports

* yarn formatted

* after lint
@erikeldridge @gsiddh
Define HybridParams
556c348
@erikeldridge @gsiddh
Copy over most types from @types package
272ff16
@erikeldridge @gsiddh
Document HybridParams and InferenceMode
aa9c4f0
@erikeldridge @gsiddh
Trim unused AI types
12e07c0
@erikeldridge @gsiddh
Assert HybridParams sets the model name
f100306
@erikeldridge @gsiddh
Use dom-chromium-ai package directly
15c4e45
@erikeldridge @gsiddh
Use multi-line JSDoc comments for enum
9786718
@erikeldridge @gsiddh
Use the existing name of the model params input
c12b529
@erikeldridge @gsiddh
Run docgen:all
bbc83d9
@erikeldridge @gsiddh
Use in-cloud phrasing
33db72a
@erikeldridge @gsiddh
Parameterize default in-cloud model name
4f22b15
@erikeldridge @gsiddh
Use type for inference mode and update docs
6df8527
@erikeldridge @gsiddh
Run yarn format
7a6c8e9
@hsubox76 @gsiddh
rebased and updated deps
eac3d4c
@hsubox76 @gsiddh
revert deps
c6a17b0
@erikeldridge @gsiddh
Remove erroneous type dep
6ccdc0e
@gsiddh gsiddh requested review from a team as code owners April 15, 2025 22:46
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 31a46a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_vertexai_responses.sh should be updated to clone the latest version of the responses: v10.0

erikeldridge
erikeldridge reviewed Apr 15, 2025
View reviewed changes
packages/vertexai/src/types/requests.ts Outdated
/**
* Optional. Specifies advanced params for on-device inference.
*/
onDeviceParams?: AILanguageModelCreateOptionsWithSystemPrompt;
Copy link

@erikeldridge erikeldridge Apr 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update AILanguageModelCreateOptionsWithSystemPrompt to LanguageModelCreateOptions now that we're using the hand-written type rather than the imported package.

erikeldridge
erikeldridge reviewed Apr 15, 2025
View reviewed changes
packages/vertexai/package.json
"@rollup/plugin-json": "6.1.0",
"@types/dom-chromium-ai": "0.0.6",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to remove this dep

erikeldridge
erikeldridge reviewed Apr 15, 2025
View reviewed changes
scripts/release/utils/workspace.ts
@@ -27,8 +27,10 @@ const writeFile = promisify(_writeFile);

const {
workspaces: rawWorkspaces
}: { workspaces: string[] } = require(`${root}/package.json`);
const workspaces = rawWorkspaces.map(workspace => `${root}/${workspace}`);
}: { workspaces: { packages: string[] } } = require(`${root}/package.json`);
Copy link

@erikeldridge erikeldridge Apr 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are from #8920 . I pulled the branch from that PR into the API change ("#⁠1") in anticipation of using the type package. Now that we're not using that package, we should revert those changes.

gsiddh and others added 5 commits April 15, 2025 16:46
@gsiddh gsiddh closed this Apr 16, 2025
@gsiddh gsiddh deleted the erikeldridge-vertex-api-2 branch April 16, 2025 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikeldridge erikeldridge erikeldridge left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gsiddh @erikeldridge @hsubox76