-
Notifications
You must be signed in to change notification settings - Fork 973
feat(ai): Add code execution #9249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 33bd257 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
.changeset/lucky-socks-roll.md
Outdated
'firebase': minor | ||
--- | ||
|
||
Add Code Execution feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added code execution feature
|
||
| Property | Type | Description | | ||
| --- | --- | --- | | ||
| [outcome](./ai.codeexecutionresult.md#codeexecutionresultoutcome) | [Outcome](./ai.md#outcome) | The result of the execution. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [outcome](./ai.codeexecutionresult.md#codeexecutionresultoutcome) | [Outcome](./ai.md#outcome) | The result of the execution. | | |
| [outcome](./ai.codeexecutionresult.md#codeexecutionresultoutcome) | [Outcome](./ai.md#outcome) | The result of the code execution. | |
|
||
| Property | Type | Description | | ||
| --- | --- | --- | | ||
| [codeExecution](./ai.codeexecutiontool.md#codeexecutiontoolcodeexecution) | {} | Specifies the Google Search configuration. Currently, this is an empty object, but it's reserved for future configuration options. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these red highlighted characters? Here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that it's just Github's syntax highlighting becoming confused, the markdown preview looks fine. I think it doesn't like the {}
and it becomes confused about seeing |
and .
characters after it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but I think we should add some mock response tests and trivial integration tests.
There's a mock response test in packages/ai/src/methods/generate-content.test.ts - can add an integration one. |
See API proposal: https://docs.google.com/document/d/1AktXyYVmeyR2L78BImDRh_8DC5YIpR_kuQxfiLFnTXA/edit?tab=t.0 (internal)
CodeExecutionTool
type that can be sent by the userExecutableCodePart
andCodeExecutionResultPart
types that can be returned from the modelAll generated documentation is in
docs-devsite/
and was copied from the API proposal.