Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
54b7edf
fix(crashlytics, iOS): reorder error reason logging to match Android …
SelaseKay Sep 11, 2025
9f4ef22
feat(crashlytics): add test event channel and CI detection for error …
SelaseKay Sep 22, 2025
3348923
fix(tests): update imports and correct test formatting for consistency
SelaseKay Sep 22, 2025
dd5ed15
fix(tests): correct import path and streamline event stream listener …
SelaseKay Sep 22, 2025
210ed6a
fix(tests): improve event channel declaration and enhance event strea…
SelaseKay Sep 22, 2025
e7a95e5
feat(crashlytics): add test event channel and modify CI detection logic
SelaseKay Sep 22, 2025
fd1b46f
fix(crashlytics): ensure main thread execution for test event success…
SelaseKay Sep 22, 2025
ba8f793
fix(crashlytics): correct formatting of crashlytics error reason for …
SelaseKay Sep 22, 2025
c2e9139
refactor(crashlytics): remove CI check from error reporting in Androi…
SelaseKay Sep 22, 2025
c0ba352
refactor(tests): comment out delay in crashlytics e2e test for faster…
SelaseKay Sep 22, 2025
2312d96
fix(tests): update event handling in crashlytics e2e test for accurat…
SelaseKay Sep 23, 2025
5ce041d
fix(tests): add missing import for async functionality in crashlytics…
SelaseKay Sep 23, 2025
4f36df7
fix(tests): add logging for received events in crashlytics e2e test
SelaseKay Sep 23, 2025
272d567
Merge branch 'main' into crashlytics_17711
SelaseKay Oct 23, 2025
eb2da85
chore: ensure testEventSink is not null before posting error reason
SelaseKay Oct 23, 2025
32020a2
chore(tests): remove unused import from firebase_crashlytics_e2e_test…
SelaseKay Oct 23, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -126,10 +126,10 @@ - (void)recordError:(id)arguments withMethodCallResult:(FLTFirebaseMethodCallRes
}

if (![reason isEqual:[NSNull null]]) {
reason = [NSString stringWithFormat:@"%@. Error thrown %@.", dartExceptionMessage, reason];
// Log additional custom value to match Android.
[[FIRCrashlytics crashlytics] setCustomValue:[NSString stringWithFormat:@"thrown %@", reason]
forKey:@"flutter_error_reason"];
reason = [NSString stringWithFormat:@"%@. Error thrown %@.", dartExceptionMessage, reason];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test to test the output? and make sure it matches between the platforms?

} else {
reason = dartExceptionMessage;
}
Expand Down
Loading