Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(py) menu example #2416

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat(py) menu example #2416

wants to merge 2 commits into from

Conversation

kirgrim
Copy link
Contributor

@kirgrim kirgrim commented Mar 21, 2025 •
edited
Loading

Description:

  • added use cases 1,2,3,5 for menu example

Dependencies:
This ticket is dependant on #2379
Rebase onto main once merged

Checklist (if applicable):

@github-actions github-actions bot added docs Improvements or additions to documentation feature New feature or request js go tooling python Python config labels Mar 21, 2025
@kirgrim kirgrim force-pushed the hrymailo/feat/py-menu-example branch from db29694 to cfac409 Compare March 21, 2025 14:17
@kirgrim kirgrim marked this pull request as draft March 21, 2025 14:17
@kirgrim kirgrim force-pushed the hrymailo/feat/py-menu-example branch from cfac409 to fef3761 Compare March 21, 2025 14:19
yesudeep
yesudeep requested changes Mar 22, 2025
View reviewed changes
py/packages/genkit/src/genkit/ai/indexer.py Outdated
@@ -0,0 +1,8 @@
# Copyright 2025 Google LLC
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please delete this license header and re-run bin/fmt to add the corrected header.

py/plugins/dev-local-vector-store/src/genkit/plugins/dev_local_vector_store/__init__.py
@@ -0,0 +1,3 @@
# Copyright 2025 Google LLC
Copy link
Contributor

@yesudeep yesudeep Mar 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: please delete this license header and regenerate throughout the PR

@kirgrim kirgrim force-pushed the hrymailo/feat/py-menu-example branch from fef3761 to cdd484c Compare March 24, 2025 15:08
@kirgrim kirgrim force-pushed the hrymailo/feat/py-menu-example branch from cdd484c to 4162346 Compare March 25, 2025 12:26
@kirgrim kirgrim force-pushed the hrymailo/feat/py-menu-example branch from 4162346 to c48d6a9 Compare March 25, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yesudeep yesudeep yesudeep requested changes

@pavelgj pavelgj Awaiting requested review from pavelgj

@ssbushi ssbushi Awaiting requested review from ssbushi

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
config docs Improvements or additions to documentation feature New feature or request go js python Python tooling
Projects
Genkit Backlog
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirgrim @yesudeep