-
Notifications
You must be signed in to change notification settings - Fork 610
feat(go): added support for durable streaming in flows #3961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @apascal07, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the streaming capabilities of Go flows by introducing durable streaming. This feature allows clients to seamlessly reconnect to ongoing or completed streaming operations, improving the robustness and user experience of applications that rely on real-time data. It provides the necessary interfaces, an in-memory implementation, and integrates this functionality directly into the existing handler mechanism, making it easy to adopt. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a significant and well-designed feature for durable streaming in Go flows. The new interfaces and the in-memory implementation are clear and robust. The integration into the HTTP server is also well-handled. I've identified a critical issue regarding error handling in durable writes, a high-severity issue with the memory cleanup strategy that could lead to a memory leak in long-running services, and a minor issue regarding a magic number. Overall, this is a great addition, and with these fixes, it will be even more solid.
| // NewInMemoryStreamManager creates a new InMemoryStreamManager. | ||
| // A background goroutine is started to periodically clean up expired streams. | ||
| // Call Close to stop the goroutine when the manager is no longer needed. | ||
| func NewInMemoryStreamManager(opts ...StreamManagerOption) *InMemoryStreamManager { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some unit tests for the in memory stream manager?
Adds support for durable streaming, allowing clients to reconnect to in-progress or completed streams using a stream ID.
Usage:
Behavior:
X-Genkit-Stream-IdheaderX-Genkit-Stream-Idin request header204 No ContentNon in-memory implementations like Firestore to follow.
Checklist (if applicable):