-
Notifications
You must be signed in to change notification settings - Fork 28
Add Embeddable integration guide for connecting to Firebolt #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
| ```javascript | ||
| const apiKey = '<your API Key>'; | ||
| const connectionName = '<some unique name>'; | ||
| const BASE_URL = 'https://api.<your-region>.embeddable.com'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Use the same naming style for variables
|
|
||
| ```javascript | ||
| const apiKey = '<your API Key>'; | ||
| const connectionName = '<some unique name>'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we define connection name here, but don't use it elsewhere. We can potentially use it in body.name field
stepansergeevitch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good!
14d01d8 to
f28df46
Compare
92e0ddd to
ec77fc6
Compare
36386c9 to
47b4972
Compare
9e524b3 to
1c46eca
Compare
1c46eca to
afafd7d
Compare
2428d23 to
856b18d
Compare
Description
Add Embeddable integration guide for connecting to Firebolt
Includes prerequisites, setup steps, API example, and links to further resources.
When should this PR be released to the public?
Immediate release.
Checklist below completed.
Documentation Checklist
make start-local(or using this tutorial)If this PR touches a function implementation (aggregate, scalar, or table-valued):
parentof my docs page is set correctly and the function shows up in the right category of the table of contents