Skip to content

Format tests/integration_tests/build/test_clippy.py #3232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 8, 2022
Merged

Format tests/integration_tests/build/test_clippy.py #3232

merged 2 commits into from
Nov 8, 2022

Conversation

StemCll
Copy link
Contributor

@StemCll StemCll commented Nov 2, 2022 •
edited
Loading

Changes

Formatted tests/integration_tests/build/test_clippy.py using Black

Reason

#3216 (comment)

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

PR Checklist

  • All commits in this PR are signed (git commit -s).
  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • New unsafe code is documented.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • This functionality can be added in rust-vmm.

@StemCll StemCll marked this pull request as ready for review November 2, 2022 15:10
@StemCll StemCll mentioned this pull request Nov 2, 2022
Merged
9 tasks
@JonathanWoollett-Light
Copy link
Contributor

JonathanWoollett-Light commented Nov 2, 2022 •
edited
Loading

The commit message is exactly 1 character too long.

https://buildkite.com/firecracker/firecracker-x86-64-intel-kernel-5-dot-10-ci/builds/1968#018438ed-9a31-4a91-aeb8-c0ab9835bf98:

Title exceeds max length (51>50): "Format tests/integration_tests/build/test_clippy.py"

@StemCll StemCll force-pushed the test_clippy_formatting branch from 12c6b2b to eaf1540 Compare November 3, 2022 16:25
@StemCll
Copy link
Contributor Author

StemCll commented Nov 3, 2022

done ✔️

@JonathanWoollett-Light JonathanWoollett-Light merged commit bf0b91d into firecracker-microvm:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dianpopa dianpopa dianpopa approved these changes

@JonathanWoollett-Light JonathanWoollett-Light JonathanWoollett-Light approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StemCll @JonathanWoollett-Light @dianpopa