Skip to content

Conversation

jrmaddison
Copy link
Contributor

Revert solver_options to solver_parameters, consistent with release and naming elsewhere in Firedrake.

Opening as PR rather than an issue as it's a small change in previously untested code.

Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible.

Copy link
Member

@dham dham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks Gusto and Spyro so will need corresponding pull requests in those projects.

@jrmaddison
Copy link
Contributor Author

I'd rather not make changes outside of Firedrake, would a backwards compatible FutureWarning be OK?

@dham
Copy link
Member

dham commented Aug 27, 2025

Hang fire briefly. We think both of these might actually be spurious in different ways so this fix might not be needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants