remove .at()
#4547
Draft
remove .at()
#4547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
reviewed
Sep 11, 2025
Comment on lines
+474
to
475
| got = dest_eval.evaluate(f_dest) | ||
| assert np.allclose(got, expected, atol=atol) |
There was a problem hiding this comment.
This test seems to unecessarily rely on point evaluation. In general we can expect that the interpolated functions agree with the linear expression everywhere on the domain, not just at the given coords. We should consider changing this to assert errornorm(f_dest, expected) <= atol where expected is the ufl.Expr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
Function.at()method. This is to go in after the next release. Users should now usePointEvaluator.