FunctionSpace: pass kwargs to finat.ufl.FiniteElement #4607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/element-kwargs
branch
from
e464470 to
3786c62
Compare
|
We got an unrelated failure in parallel (no variants involved), maybe that's random. I'll rerun CI |
connorjward
reviewed
Sep 30, 2025
There was a problem hiding this comment.
Now that we know that some in the team don't like **kwargs too much I think we should let them review this. Personally I think this is fine since it means we won't need to change a bunch of functions every time a new option is added to the finite element constructor.
It would also be good for these to have type hints as there currently appears to be no type information for all of these very public functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This enables
variantandquad_schemeto be passed on to finat direclty from theFunctionSpaceconstructor.I don't think that tests for
quad_schemeare necessary at this point, as we already have tests forvariant.