BUG: fix reuse of matfree adjoint Interpolator #4623
+58
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/remove-weight-parloop
branch
from
df3e169 to
ed3f5b9
Compare
pbrubeck
changed the title
pbrubeck
commented
Oct 6, 2025
pbrubeck
force-pushed
the
pbrubeck/remove-weight-parloop
branch
from
ed3f5b9 to
462f355
Compare
|
Is there any chance this could be two PRs? It's hard to understand the parallel bits when mixed into the other changes. Also note that the halo freezing stuff is done automatically in pyop3, so maybe you don't have to worry about optimising that here. |
pbrubeck
force-pushed
the
pbrubeck/remove-weight-parloop
branch
4 times, most recently
from
d8d6687 to
19fa12e
Compare
I'm having a hard time with git. The parloop removal is the only other thing that's not adressing the bug, should be easy to ignore from the rest of the PR. |
pbrubeck
commented
Oct 6, 2025
pbrubeck
commented
Oct 6, 2025
pbrubeck
commented
Oct 6, 2025
pbrubeck
commented
Oct 6, 2025
pbrubeck
commented
Oct 6, 2025
pbrubeck
commented
Oct 6, 2025
pbrubeck
force-pushed
the
pbrubeck/remove-weight-parloop
branch
4 times, most recently
from
347184c to
7d4b07a
Compare
pbrubeck
force-pushed
the
pbrubeck/remove-weight-parloop
branch
from
7d4b07a to
f7dbe9b
Compare
pbrubeck
commented
Oct 7, 2025
pbrubeck
force-pushed
the
pbrubeck/remove-weight-parloop
branch
from
800bf4c to
21c9173
Compare
pbrubeck
force-pushed
the
pbrubeck/remove-weight-parloop
branch
from
948c50e to
1a35688
Compare
connorjward
requested changes
Oct 9, 2025
pbrubeck
changed the title
Co-authored-by: Connor Ward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a parallel bug when reusing a matfree adjoint
Interpolator. Summation withaccess=INCskipped the halo exchange after the first call toInterpolator.assemble(). On subsequent calls the summation only happened locally within each process, but not across processes.This bug did not affect
assemble(interpolate(...))because the Interpolator there is never reused.