Skip to content

Conversation

qbisi
Copy link
Contributor

@qbisi qbisi commented Oct 6, 2025

test_high_order_location_warped_interior_facet failed when i try to package firedrake-2025.10.0 in nxipkgs.

The failure happens because the point [0.25, 0.605] lies right on the boundary between the warped cells 1 and 3. In the test, we ignore cell 3 and assert that the point belongs to cell 1.

If you have plan retagging v2025.10.0, i will hold on the upgrade of firedrake in nixpkgs. Otherwise, i will apply a simple patch to it.

@connorjward
Copy link
Contributor

From my reading of the test this point should comfortably lie inside the cell. Any other result is a bug.
For your use case I would recommend patching out the test. But please feel free to open an issue.

@qbisi
Copy link
Contributor Author

qbisi commented Oct 6, 2025

By reducing warp offset from 0.1 to 0.04, some how alleviate the pain caculating if a point is belonged to a concave cell e.g. (cell 3 in this example). Still the edge points for cell3 does not match with cell1 everywhere.
I think the real problem is locate_cell consider some outer points in the concave cell via transformation.

Issue: #4627

@qbisi qbisi changed the title test_warped_interior_facet: ignore cell number 3 on the edge point test_warped_interior_facet: reduce warp shift Oct 6, 2025
@qbisi qbisi changed the title test_warped_interior_facet: reduce warp shift test_warped_interior_facet: reduce warp offset Oct 6, 2025
@qbisi
Copy link
Contributor Author

qbisi commented Oct 7, 2025

superseded by #4632

@qbisi qbisi closed this Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants