forked from jsbroks/coco-annotator
-
Notifications
You must be signed in to change notification settings - Fork 1
Enable tagging and filtering datasets #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jcerdenia
wants to merge
16
commits into
master
Choose a base branch
from
feature/tag-and-filter-datasets
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unctionality to 'default_annotation_metadata' instead
tintn
approved these changes
Jul 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The backend part LGTM! Did you check if the new schema will work with the current dataset collection because the dataset entries do not have tags
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Currently, datasets are arranged in the dataset viewer in a flat structure, making it difficult to manage a large number of datasets. This PR introduces two features to address this problem:
1. Ability to tag a dataset with arbitrary keys and values.
An interface is added to the client side for inputting keys and values for each dataset. Keys must be unique per dataset.

On the server side, the tags are held in each dataset document in a
tags
dictionary property.2. Ability to filter datasets in the dataset viewer according to tags.
An input form is added to the client to be able to type or select tags that can be used to filter the datasets on the server side. The tag options come from a new API route that serves all unique tags across all datasets per user.

Wishes
@tintn @niccololampa This PR does not yet include a new 'Tags' page in the UI. The basic functionality is there but I'm thinking a separate Tags page would be needed to enable assigning tags to existing datasets in bulk. I can continue to work on it here or create a new PR to prevent this one from becoming too big -- please let me know what you think.