Skip to content

Enable tagging and filtering datasets #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

jcerdenia
Copy link
Member

Purpose

Currently, datasets are arranged in the dataset viewer in a flat structure, making it difficult to manage a large number of datasets. This PR introduces two features to address this problem:

1. Ability to tag a dataset with arbitrary keys and values.

An interface is added to the client side for inputting keys and values for each dataset. Keys must be unique per dataset.
Screen Shot 2022-07-08 at 4 38 10 PM

On the server side, the tags are held in each dataset document in a tags dictionary property.

2. Ability to filter datasets in the dataset viewer according to tags.

An input form is added to the client to be able to type or select tags that can be used to filter the datasets on the server side. The tag options come from a new API route that serves all unique tags across all datasets per user.
Screen Shot 2022-07-08 at 4 38 49 PM

Wishes

@tintn @niccololampa This PR does not yet include a new 'Tags' page in the UI. The basic functionality is there but I'm thinking a separate Tags page would be needed to enable assigning tags to existing datasets in bulk. I can continue to work on it here or create a new PR to prevent this one from becoming too big -- please let me know what you think.

@jcerdenia jcerdenia requested review from tintn and niccololampa July 8, 2022 09:11
@jcerdenia jcerdenia changed the title Feature/tag and filter datasets Enable tagging and filtering datasets Jul 8, 2022
Copy link
Collaborator

@tintn tintn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backend part LGTM! Did you check if the new schema will work with the current dataset collection because the dataset entries do not have tags?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants