fix docker build CI

[aleflm]

PR intention

Fix docker CI issue. https://github.com/aleflm/firo/actions/runs/18649626869

[coderabbitai]

Walkthrough

Updated the Dockerfile build stage by adding five build-essential packages—autoconf, build-essential, cmake, file, and m4—to the apt-get install command. Applied minor formatting standardization by capitalizing the FROM directive alias from "as" to "AS".

Changes

Cohort / File(s)	Summary
Build dependencies Dockerfile	Added build tools (autoconf, build-essential, cmake, file, m4) to build-stage apt-get install
Formatting Dockerfile	Capitalized FROM directive alias from "as build-image" to "AS build-image"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With cmake, autoconf, and m4 in sight,
Our Docker image builds with all its might,
Build-essential tools now stack up tall,
A proper AS directive crowns it all!
✨ Dependencies bound, the build's now right!

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description Check	❓ Inconclusive	The PR description includes the mandatory "PR intention" section and states the intent to "Fix docker CI issue" with a reference to the failing CI run. However, the description is quite vague and lacks specificity about what the actual fix entails—a reader would not understand from the description alone that the solution involves adding build dependencies to the Dockerfile. While the mandatory section is technically present, the brevity and lack of detail about the specific changes make the description somewhat generic.	Expand the "PR intention" section to provide more specific details about the fix—explain that the change adds required build dependencies (autoconf, build-essential, cmake, file, and m4) to the Docker build stage and why these packages are needed to resolve the CI failure. This will give reviewers a clear understanding of what was changed and why without requiring them to examine the raw code diff.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "fix docker build CI" is directly related to the main change in the pull request, which involves fixing a Docker CI build issue by adding necessary build dependencies (autoconf, build-essential, cmake, file, and m4) to the Dockerfile. The title is concise and specific enough that a reviewer scanning the commit history would understand this is about fixing Docker-related CI problems. While not exhaustively detailed about the specific fix mechanism, it accurately reflects the purpose of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

Dockerfile (1)

9-9: Minor redundancy: g++ is included both explicitly and via build-essential.

The build-essential metapackage (line 9) already includes g++, making the explicit g++ entry on line 13 redundant. While apt-get handles this gracefully without issues, consolidating the package list would improve clarity.

Consider removing the explicit g++ entry:

     automake \
     bsdmainutils \
     build-essential \
     cmake \
     curl \
     file \
-    g++ \
     libtool \
     m4 \

Alternatively, if g++ is intentionally pinned separately for version control, add a clarifying comment.

Also applies to: 13-13

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22bd437 and 685e011.

📒 Files selected for processing (1)

• Dockerfile (1 hunks)

🔇 Additional comments (2)

Dockerfile (2)

2-2: Good practice: Uppercase Dockerfile directives.

Capitalizing the FROM directive to "AS" aligns with Dockerfile conventions and improves consistency.

---

6-18: Added packages appropriately address build dependencies.

The added packages (autoconf, build-essential, cmake, file, m4) are necessary to support the build pipeline:

• autoconf and m4 are required by the ./autogen.sh script (line 28)
• build-essential ensures all core build tools are available
• cmake likely supports dependency builds
• file is a utility sometimes required during build chains

This fix directly addresses the CI failure by ensuring all required build dependencies are present.