add warning when quant config exists but quantization fails #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GandalfTea
force-pushed
the
warn-quant-fail
branch
from
098678f to
49dea1f
Compare
andthattoo
reviewed
Nov 28, 2025
Member
There was a problem hiding this comment.
Wouldn't it be better to raiseException since we don't/can't run a model once it's not correctly quantized?
andthattoo
reviewed
Nov 28, 2025
Member
andthattoo
left a comment
andthattoo
left a comment
There was a problem hiding this comment.
Wouldn't it be better to raiseException since we don't/can't run a model once it's not correctly quantized?
GandalfTea
force-pushed
the
warn-quant-fail
branch
from
49dea1f to
a41a057
Compare
GandalfTea
force-pushed
the
warn-quant-fail
branch
from
a41a057 to
a3570b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Log a warning when a quantization config is found in
apply_quantization_from_configbutnn.quantizefails.Changes
apply_quantization_from_configto returnTuple[boo, bool], the first is true ifg_bitsandg_groupare non 0 and the second is the result fromnn.quantizeShardRuntimeto issue log when bits/group are present but nn.quantize failed.Testing
Tested with a failing version of
qwen3_moemodel implementation file.