Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: replace ESLint and Prettier with Biome #79

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

fityannugroho
Copy link
Owner

@fityannugroho fityannugroho commented Oct 18, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

Put [x] to check

  • I have read the documentation.
  • I have read and followed the Contributing Guidelines.
  • I have included a pull request description of my changes.
  • I have included the necessary changes to the documentation.
  • I have added tests to cover my changes.

PR Type

What kind of change does this PR introduce?

Please check any kind of changes that applies to this PR using [x]

  • Bug fix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.

Issue Number: N/A

What is the new behavior?

This pull request introduces significant changes to the project configuration and codebase, focusing on replacing Prettier and ESLint with Biome, improving code readability, and updating dependencies. Below are the most important changes grouped by theme:

Configuration Updates:

  • Removed .prettierignore and .prettierrc.json files as part of the transition to Biome. (.prettierignore [1] .prettierrc.json [2]
  • Added a new biome.json configuration file to define Biome settings, including version control, file ignoring, formatting, linting, and JavaScript-specific rules. (biome.json biome.jsonR1-R66)
  • Updated eslint.config.js to remove ESLint and Prettier configurations. (eslint.config.js eslint.config.jsL1-L17)

Dependency and Script Changes:

  • Updated package.json to replace ESLint and Prettier dependencies with Biome, and modified linting scripts to use Biome. (package.json [1] [2]
  • Simplified and cleaned up package.json by reformatting array items and removing unnecessary dependencies. (package.json package.jsonL26-R24)

Codebase Improvements:

  • Modified imports in src/cli.ts, src/downloader.ts, src/index.ts, and test files to improve readability and consistency, such as using type imports and reordering import statements. (src/cli.ts [1] [2] [3] src/downloader.ts [4] [5] [6] [7] src/index.ts [8] [9] [10] test/cli.spec.ts [11] test/downloader.spec.ts [12] test/fixtures/mocks/handlers.ts [13] test/index.spec.ts [14] [15] [16] [17] [18] [19]

These changes streamline the project's configuration and improve code maintainability.

Other information

None

@fityannugroho fityannugroho added the dependencies Pull requests that update a dependency file label Oct 18, 2024
@fityannugroho fityannugroho merged commit d675d39 into main Oct 18, 2024
3 checks passed
@fityannugroho fityannugroho deleted the refactor/biomejs branch October 18, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant