Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#15] Writing data on closed socket causes unnecessary exception #19

Open
wants to merge 1 commit into
base: netty4
Choose a base branch
from
Open

[#15] Writing data on closed socket causes unnecessary exception #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/cloudhopper/smpp/impl/DefaultSmppSession.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -507,6 +507,11 @@ public WindowFuture<Integer,PduRequest,PduResponse> sendRequestPdu(PduRequest pd
}
}

if (!this.channel.isOpen()) {
logger.info("Channel closed.");
return future;
}

// write the pdu out & wait timeout amount of time
ChannelFuture channelFuture = this.channel.writeAndFlush(buffer);
if (configuration.getWriteTimeout() > 0){
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/com/cloudhopper/smpp/impl/DefaultSmppServerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,8 +461,9 @@ public void serverSessionTimesOutWithNoBindRequest() throws Exception {
try {
BaseBindResp bindResponse = session0.bind(bindRequest, 200);
Assert.fail();
} catch (SmppChannelException e) {
} catch (SmppTimeoutException e) {
// correct behavior
logger.debug("Got expected timeout exception {}", e.getMessage());
}

// verify everything after the session timed out
Expand Down