Migrate to golangci-lint v2 and optimize CI/CD #51
+1,280
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply all learnings from protect-rpc optimization work: **Config changes:** - Migrate .golangci.yaml to v2 schema (default: all, nested settings) - Disable noisy linters: funcorder, noinlineerr, wsl_v5, complexity metrics - Keep tagliatelle enabled (new projects should use snake_case JSON) **CI optimization:** - Use golangci-lint-action@v8 (pre-built binaries, no compilation) - Extract version from go.mod for local/CI consistency - Simplify workflow by removing manual tool installation **Tool management:** - Add tools/tools.go with blank imports (single source of truth) - Remove staticcheck (bundled in golangci-lint) - Add gci for import formatting - Simplify Makefile to use go.mod versions **Bug fixes:** - Fix gosec warnings: explicitly handle w.Write() errors 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Config Migration:
.golangci.yaml: Updated to v2 schema (default: all, nestedlinters.settings)CI Optimization:
.github/workflows/checks.yml: Use golangci-lint-action@v8 with pre-built binariesmake install-toolsstep (action handles it)Tool Management:
tools/tools.go: New file with blank imports (single source of truth for tool versions)Makefile: Simplified to use go.mod versions (removed @Version suffixes)Bug Fixes:
httpserver/handler.go: Explicitly handle w.Write() errors to satisfy gosecTest Plan
make install-tools- Tools install correctly from go.modmake lint- 0 issues locallymake test- All tests passLearnings Applied
All changes are based on optimizations discovered while migrating protect-rpc from golangci-lint v2.1.2 to v2.5.0, where we:
🤖 Generated with Claude Code