Accept jsonRpcError as error type in rpcserver pkg #53
+90
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeyldii
force-pushed
the
feature/custom-rpc-errors
branch
from
9f9a1dd to
3fa3ecd
Compare
jeyldii
force-pushed
the
feature/custom-rpc-errors
branch
from
0642639 to
8fb5370
Compare
metachris
reviewed
Aug 13, 2025
rpcserver/reflect.go
Outdated
| @@ -13,21 +13,24 @@ var ( | |||
| ErrMustReturnError = errors.New("function must return error as a last return value") | |||
| ErrMustHaveContext = errors.New("function must have context.Context as a first argument") | |||
| ErrTooManyReturnValues = errors.New("too many return values") | |||
| ErrVariadicArgument = errors.New("variadic argument is only allowed to be sole") | |||
There was a problem hiding this comment.
please clarify / rephrase "only allowed to be sole" -- unclear meaning
jeyldii
force-pushed
the
feature/custom-rpc-errors
branch
from
cfd2b2f to
fbf0eaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.