Add reproducible builds #233
Conversation
SozinM
requested review from
ferranbt,
avalonche and
karim-agha
as code owners
SozinM
force-pushed
the
msozin/make-release-reproducible
branch
from
6fae7bb to
cb9b9c8
Compare
SozinM
changed the title
|
@SozinM manually requesting you to review since Github won't let me request your review on your own PR |
| @@ -100,8 +100,12 @@ jobs: | |||
| run: | | |||
| git config --global --add safe.directory "$(pwd)" | |||
| . $HOME/.cargo/env | |||
| cargo build --release --features=${{ matrix.features }} --target ${{ matrix.configs.target }} --package op-rbuilder | |||
|
|
|||
| SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct) \ | |||
There was a problem hiding this comment.
not sure it will work
| @@ -0,0 +1,33 @@ | |||
| name: Verify Reproducible Build | |||
There was a problem hiding this comment.
i think the best idea is to run this on schedule once a week / couple of days for example
This way we will notice if something has broken repro builder, but won't wait for this to pass on every PR, because it will take a LOT of time
There was a problem hiding this comment.
I figured we were just going to run this manually whenever we have a release that we want to put in a new image. Every 3-4 days def wouldn't hurt though. I'll add that.
| ARG FEATURES | ||
| WORKDIR /app | ||
| COPY . . | ||
| RUN SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct) \ |
There was a problem hiding this comment.
This will force docker to build this 2 times (and one of them would be slow build), let's do it better
There was a problem hiding this comment.
You are compiling regular build + reproducible build
Doesn't really make sense, because you could separate them or use a flag to build one or the other.
This now inside the check we are running instead of compiling once we would compile both of the, and probably go from 2min -> 10min
There was a problem hiding this comment.
Ahh I see. That RUN command means that the builds are actually happening during docker build, not docker run. I can just add a --target flag to the PR workflow to force it to build only the non-reproducible. Does that solve the problem?
📝 Summary
From reth
https://github.com/paradigmxyz/reth/blob/f30016019d592e36b31b48feb8adf3292c04b626/Makefile#L83
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test