feat: implement p2p layer and broadcast flashblocks #275
Conversation
crates/p2p/src/behaviour.rs
Outdated
| } | ||
|
|
||
| #[allow(clippy::large_enum_variant)] | ||
| #[derive(Debug)] |
There was a problem hiding this comment.
You can use derive_more::From to get rid of the manual From impls below
| } | ||
|
|
||
| impl NodeBuilder { | ||
| pub fn new() -> Self { |
There was a problem hiding this comment.
there is default() also, I like having both
| loop { | ||
| match reader.next().await { | ||
| Some(Ok(str)) => { | ||
| let payload: M = serde_json::from_str(&str) |
There was a problem hiding this comment.
Shouldn't deserialization happen in op-rbuilder code?
There was a problem hiding this comment.
i originally had it there, i was debating if the serialization format should be internal or external to the p2p layer. i'm going to refactor this to not be json anyways. could change the p2p layer back to just handle Bytes instead of Message if you prefer that
There was a problem hiding this comment.
sounds good, i'll look again after you refactor
out of scope for this PR, i am assuming the high availability setup will be used where op-conductor will manage which party is building at a specific time.
yes will add! PR is still draft, not ready for review yet tbh, will ping you again when it's fully ready. |
| &self.evm_config | ||
| } | ||
|
|
||
| pub(super) fn into_op_payload_builder_ctx( |
There was a problem hiding this comment.
why not for conversions between the types?
There was a problem hiding this comment.
i'm probably going to remove this function after cleanup
noot
changed the title
📝 Summary
future extensions:
💡 Motivation and Context
see https://hackmd.io/@nZ-twauPRISEa6G9zg3XRw/H1fekrwolx
✅ I have completed the following steps:
make lintmake test