Add flashtestation builder tx #282
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avalonche
force-pushed
the
add-flashtestation-builder-tx
branch
from
46380ae to
41c42bf
Compare
avalonche
force-pushed
the
updated-registration
branch
from
79aff67 to
0b9b3a3
Compare
avalonche
force-pushed
the
add-flashtestation-builder-tx
branch
from
41c42bf to
01573b2
Compare
SozinM
reviewed
Oct 2, 2025
| where | ||
| E: core::error::Error + Send + Sync + 'static, | ||
| { | ||
| BuilderTransactionError::Other(Box::new(error)) |
There was a problem hiding this comment.
If we want to be fancy we could impl From< T > for BuilderTransactionError where T: core::error::Error + Send + Sync + 'static
| } | ||
|
|
||
| #[derive(Debug, Default)] | ||
| pub struct TxSimulateResult { |
There was a problem hiding this comment.
Can we put revm ExecutionResult in here? Will replace couple of fileds
| let verify_block_proof_tx = self.signed_block_builder_proof_tx( | ||
| block_content_hash, | ||
| ctx, | ||
| gas_used * 64 / 63, |
There was a problem hiding this comment.
let's wrap this with function?
| ); | ||
| debug!(target: "flashtestations", block_number = ctx.block_number(), tx_hash = ?verify_block_proof_tx.tx_hash(), "adding verify block proof tx to builder txs"); | ||
| Ok(Some(BuilderTransactionCtx { | ||
| gas_used, |
There was a problem hiding this comment.
should gas_used * 64/63 be accounted in here?
avalonche
force-pushed
the
updated-registration
branch
from
0b9b3a3 to
581ebac
Compare
avalonche
force-pushed
the
add-flashtestation-builder-tx
branch
from
01573b2 to
32146ac
Compare
avalonche
force-pushed
the
updated-registration
branch
from
581ebac to
8768d27
Compare
avalonche
force-pushed
the
add-flashtestation-builder-tx
branch
from
32146ac to
2499332
Compare
Co-authored-by: Solar Mithril <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Add flashtestations builder tx and registration logic into built block
💡 Motivation and Context
✅ I have completed the following steps:
make lintmake test