-
Notifications
You must be signed in to change notification settings - Fork 17
fix: loosen bounds on CheckpointContext so we can override it #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
julio4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the issue but we still want to make context accessible in build_payload (as introduced in #97).
If we loosen bounds here we should find a way to still pass extra context info to build payload, maybe not as CheckpointContext?
What is the use case for passing extra context info build payload? |
Being able to reuse some already computed infos to construct final payload (such as receipts). Atleast that's the idea |
Honestly this is pretty vague to me... do you have a code reference to us doing this anywhere or a doc detailing this requirement? unichain-builder being able to compile from the latest rblib commit is a top priority |
This is a feature we want because right now the => Having a way to share parts of the computation artifacts of checkpoints to the build payload function will allows platforms to implement performant final payload building. But I agree for unichain-builder close feedback loop on last main commit, we can revert the changes after confirming how it is currently used and find a similar way that don't reduce platform flexibility too much. |
julio4
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's merge it for now and revisit with an alternative solution
The restriction introduced in #97 meant that we can't define our own custom checkpoint context when using the optimism platform functions.
See flashbots/unichain-builder#55