numbl interface#842
Draft
magland wants to merge 6 commits into
Draft
Conversation
Collaborator
Author
Replace the per-function .js / wrapper.cpp pair with a single finufft.js builtin backed by a minimal mex C API shim, so the upstream finufft.cpp (the mwrap-generated MEX source) can be compiled unmodified into both finufft.wasm and finufft.so. The unmodified upstream finufft_plan.m and finufftNd? simple-interface m-files now run through this builtin without any numbl-specific overrides. Subtle: finufft_setpts stores xj/yj/zj pointers without copying them, so finufft.js retains the input mxArrays per-plan and frees them on destroy.
Collaborator
Author
|
Reworked the numbl interface to be a drop-in replacement for the MEX file rather than a parallel set of overrides.
All 6 scripts in |
…rnings Refactor mexPrintf / mexErrMsgIdAndTxt to early-return / call the noreturn mexErrMsgTxt directly when fmt is null, instead of passing an empty literal as the format string. Cosmetic; no behavior change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This shows what needs to be added to support finufft in numbl.