Conversation
WardBrian
requested changes
Jun 2, 2026
Collaborator
Author
|
I realized I didn't finish these before submitting the PR. Let me go back and do that before you merge. |
Collaborator
Author
|
@WardBrian I added the rest of the tests, so this is ready to review again. |
WardBrian
approved these changes
Jun 3, 2026
WardBrian
left a comment
WardBrian
left a comment
Collaborator
There was a problem hiding this comment.
One minor thing but otherwise looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a pretty comprehensive test for everything in
walnuts(notwalnuts::detail) forsummary.hpp.I also reformatted, so there's a bunch of distractions from that---sorry about that.