Add feature for upload flatpak bundle to some github release tag #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flatpak-builder/index.js
Outdated
| } | ||
| }) | ||
| if (exitCodeUploadToGithub !== 0) { | ||
| throw Error('flat-manager-client failed to upload to GitHub') |
There was a problem hiding this comment.
It is not flat-manager-client that can fail here, no?
There was a problem hiding this comment.
flat-manager-client won't fail, but gh may fail because of tag not exist, tag time more than 3 hours, etc.
There was a problem hiding this comment.
then the error should not talk about flat-manager.
There was a problem hiding this comment.
It's 'Failed to upload to GitHub' now.
|
the changes are not enough, you need to follow https://github.com/flatpak/flatpak-github-actions/blob/master/CONTRIBUTING.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #207