-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to register app ID #183
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the only thing I think is missing is the documentation blocks for introspection.
Tweaked the qt examples a bit. The qt5 one now plumbs the app Id via |
These are no-ops when running under flatpak or snap, but when running on the host, they will call Register() on org.freedesktop.host.portal.Registry.
|
Does this mean it would be more correct to call them as |
Exactly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check whether the Qt code paths can be improved based on what @ilya-fedin said
Meant to be used by host apps to more reliably get an app ID. See flatpak/xdg-desktop-portal#1521.